Quick answer
There is no single best moment — each path has its own window. Paid upgrades close hours before departure, miles seats sell out when the space goes, and day-of offers appear at check-in. Checking both early and near travel day covers the realistic paths.
